Update twine from 1.8.1 to 1.11.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisheksinha89
approved these changes
May 8, 2018
pensivebrian
reviewed
May 8, 2018
| @@ -63,7 +63,7 @@ def configure_and_update_options(options): | |||
|
|
|||
| if not options.integrated_auth: | |||
| if not options.username: | |||
| options.username = input(u'Username (press enter for sa)') or u'sa' | |||
| options.username = input(u'Username (press enter for sa):') or u'sa' | |||
There was a problem hiding this comment.
PR of the month right here! This has bugged me for so long :)
There was a problem hiding this comment.
My mistake is finally corrected
pensivebrian
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During publish step we encounter this issue:
pypa/twine#342
Updating twine is the fix.
Added missing colon to default prompt for user name.
Added format fix for version display on prompt.